> On March 2, 2015, 10:46 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 773 > > <https://reviews.apache.org/r/31644/diff/1/?file=882398#file882398line773> > > > > It seems a bit weird to remove the slave while there are still tasks > > and executors that need to be removed. Do you think we need the same > > comment as in removeSlave? > > > > ``` > > // We want to remove the slave first, to avoid the allocator > > // re-allocating the recovered resources. > > ```
done. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31644/#review74842 ----------------------------------------------------------- On March 2, 2015, 10:25 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31644/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 10:25 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2403 > https://issues.apache.org/jira/browse/MESOS-2403 > > > Repository: mesos > > > Description > ------- > > This is a short term fix for MESOS-2403. > > > Diffs > ----- > > src/master/master.cpp 53c8696fbe95792c40d7950a94c92f64c49ab892 > > Diff: https://reviews.apache.org/r/31644/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
