-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31645/#review74868
-----------------------------------------------------------


Patch looks great!

Reviews applied: [31645]

All tests passed.

- Mesos ReviewBot


On March 2, 2015, 11:44 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31645/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 11:44 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-2372
>     https://issues.apache.org/jira/browse/MESOS-2372
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade path test script runs previous and new framework versions (i.e. 
> different versions of test framework+libmesos) against different versions of 
> mesos slave and master. We can hopefully generate the upgrade paths we want 
> to test systematically (applying some combinatorics) and cover those in this 
> script.
> 
> 
> Diffs
> -----
> 
>   support/test-upgrade.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31645/diff/
> 
> 
> Testing
> -------
> 
> The output from running the script against 0.21.0 and HEAD (0.23.0):
> 
> $ python ./support/run-upgrade.py --prev=../mesos/build-0.21.0/ --next=build
> Running upgrade test from mesos 0.21.0 to mesos 0.23.0
> +--------------+----------------+----------------+---------------+
> | Test case    |   Framework    |     Master     |     Slave     |
> +--------------+----------------+----------------+---------------+
> |    #1        |  mesos 0.21.0  | mesos 0.21.0   | mesos 0.21.0  |
> |    #2 (live) |  mesos 0.21.0  | mesos 0.21.0   | mesos 0.23.0  |
> |    #3        |  mesos 0.23.0  | mesos 0.21.0   | mesos 0.23.0  |
> |    #4        |  mesos 0.23.0  | mesos 0.23.0   | mesos 0.23.0  |
> +--------------+----------------+----------------+---------------+
> 
> NOTE: live denotes that master process keeps running from previous case.
> 
> 
> Test case 1 (Run of previous setup)
> ##### Starting mesos 0.21.0 master #####
> Run ['../mesos/build-0.21.0/bin/mesos-master.sh', '--ip=127.0.0.1', 
> '--work_dir=/var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmp2UMcJv', 
> '--credentials=/var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T
> /tmpEMpQQd'], output: 
> /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpEXE5wH
> ##### Starting mesos 0.21.0 slave #####
> Run ['../mesos/build-0.21.0/bin/mesos-slave.sh', '--master=localhost:5050', 
> '--credential=/var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpEMpQQd'], 
> output: /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000
> gn/T/tmpnGiJfB
> ##### Starting mesos 0.21.0 framework #####
> Waiting for mesos 0.21.0 framework to complete (10 sec max)...
> Run ['../mesos/build-0.21.0/src/test-framework', '--master=localhost:5050'], 
> output: /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmp5cfI3A
> 
> Test case 2 (Upgrade of slave)
> ##### Stopping mesos 0.21.0 slave #####
> ##### Starting mesos 0.23.0 slave #####
> Run ['build/bin/mesos-slave.sh', '--master=localhost:5050', 
> '--credential=/var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpEMpQQd'], 
> output: /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpj9sM2K
> ##### Starting mesos 0.21.0 framework #####
> Waiting for mesos 0.21.0 framework to complete (10 sec max)...
> Run ['../mesos/build-0.21.0/src/test-framework', '--master=localhost:5050'], 
> output: /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpltfC_p
> 
> Test case 3 (Upgrade framework)
> ##### Starting mesos 0.23.0 framework #####
> Waiting for mesos 0.23.0 framework to complete (10 sec max)...
> Run ['build/src/test-framework', '--master=localhost:5050'], output: 
> /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpJVWJjW
> 
> Test case 4 (Run of next setup)
> ##### Stopping mesos 0.23.0 slave ####
> ##### Stopping mesos 0.21.0 slave ####
> Run ['build/bin/mesos-master.sh', '--ip=127.0.0.1', 
> '--work_dir=/var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpALCpmO', 
> '--credentials=/var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpEMpQQd'], 
> o$tput: /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmp6oLkTt
> ##### Starting mesos 0.23.0 slave #####
> Run ['build/bin/mesos-slave.sh', '--master=localhost:5050', 
> '--credential=/var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpEMpQQd'], 
> output: /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpYOCLCM
> ##### Starting mesos 0.23.0 framework #####
> Waiting for mesos 0.23.0 framework to complete (10 sec max)...
> Run ['build/src/test-framework', '--master=localhost:5050'], output: 
> /var/folders/y3/w04yjljd5gbcvbvxvd5bhmp40000gn/T/tmpCVjtu3
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Reply via email to