> On Feb. 21, 2015, 3:23 a.m., Michael Park wrote: > > This seems like a small subset of regex, can we just use > > `boost::regex_match` for now with the intention that we'll switch to > > `std::regex_match` later on? The only thing would be that we'll have to > > update our bundled `boost` to include `regex`. > > Alexander Rojas wrote: > I couldn't agree more. However in our code only stout has a dependency to > boost and this dependency is header only. Using `boost::regex` will add a > binary dependency, which is the reason I didn't do it.
Following what >mcypark said, it would be useful to at least add a TODO for `std::regex_match`. - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31227/#review73392 ----------------------------------------------------------- On Feb. 24, 2015, 9:16 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31227/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 9:16 a.m.) > > > Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2333 > https://issues.apache.org/jira/browse/MESOS-2333 > > > Repository: mesos > > > Description > ------- > > Adds a function `wildcardMatching` which takes a string to be match and a > pattern and returns true if the string matches the pattern. > > The patter is a string where the special characters '*' and '?' are usind as > wildcards. '*' is used as "any character, zero or more times" while '?' is > used as "any character exactly once". > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp > 46b79bc5c11cb1878ffccb4c0c8bb8a49ee9832d > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp > b90057972d22123d655697425581cc2767ec825d > > Diff: https://reviews.apache.org/r/31227/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
