> On Feb. 16, 2015, 6:06 p.m., Jie Yu wrote: > > src/master/validation.cpp, lines 217-218 > > <https://reviews.apache.org/r/30952/diff/3/?file=864861#file864861line217> > > > > Do you want to add a test, or there is a test already?
This type of validations that are directly on accept and that shouldn't be tested through the driver will be on the API's tests. - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/#review72634 ----------------------------------------------------------- On Feb. 16, 2015, 8:53 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30952/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 8:53 a.m.) > > > Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2290 > https://issues.apache.org/jira/browse/MESOS-2290 > > > Repository: mesos-incubating > > > Description > ------- > > There is a scheduler validation > (https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L275) > missing in master. See motivation on MESOS-2288. > > > Diffs > ----- > > src/master/master.hpp 6a39df0 > src/master/master.cpp f10a3cf > src/master/validation.cpp acc35b2 > > Diff: https://reviews.apache.org/r/30952/diff/ > > > Testing > ------- > > make check and distcheck. Tests will be added with new HTTP API endpoints > tests. > > > Thanks, > > Isabel Jimenez > >
