----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31276/#review75001 -----------------------------------------------------------
src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31276/#comment121924> I'm not following how everything is structured here, i.e., the division between what's done in the helper and what's in the tests. I was thinking we'd write test bodies like: // create memory cgroup // create helper, place it into cgroup // instruct helper to consume X bytes of memory and/or write X bytes to file // have expectations on number of pressure events, depending on previous actions // repeat conbinations of above to test different pressure scenarios // clean up Phrased slightly differently: the helper would be "dumb" it would contain no test logic, just the knobs to turn so a child process in the cgroup consumes memory in different ways. Different tests would turn those knobs in different ways. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31276/#comment121907> s/evitable/evictable/ src/tests/memory_test_helper.cpp <https://reviews.apache.org/r/31276/#comment121903> s/in inevictable/unevictable/ src/tests/memory_test_helper.cpp <https://reviews.apache.org/r/31276/#comment121906> s/conntent/content/ src/tests/memory_test_helper.cpp <https://reviews.apache.org/r/31276/#comment121910> s/Unpected/Unexpected/ - Ian Downes On Feb. 25, 2015, 1:59 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31276/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 1:59 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: mesos-2136 > https://issues.apache.org/jira/browse/mesos-2136 > > > Repository: mesos > > > Description > ------- > > Added cgroup memory pressure listening tests. > > > Diffs > ----- > > src/Makefile.am f9e697547906bf82032734ee78135536ad832449 > src/tests/cgroups_tests.cpp 75c61aad80f894acb92a9752e8d1b6af70e5b9a6 > src/tests/memory_test_helper.hpp PRE-CREATION > src/tests/memory_test_helper.cpp PRE-CREATION > src/tests/memory_test_helper_main.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31276/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
