----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review75009 -----------------------------------------------------------
src/slave/metrics.cpp <https://reviews.apache.org/r/30074/#comment121931> Let's preserve the ordering you have above :) src/slave/metrics.cpp <https://reviews.apache.org/r/30074/#comment121932> Same here src/slave/slave.hpp <https://reviews.apache.org/r/30074/#comment121933> Same as above. src/slave/slave.cpp <https://reviews.apache.org/r/30074/#comment121928> Even though age() returns a Duration, it's not clear from the calling code. We could make it explicit by introducing a CHECK() We could also have a local variable with the age which we set just before the delay so we don't have to .get(). Bot no biggies, but to catch if someone changes the return type of age() src/slave/slave.cpp <https://reviews.apache.org/r/30074/#comment121930> How about using Slave::age(0) i.e. Assume that tasks don't take up any space yet. That will be closer to the number users will get after it has been measured. src/slave/slave.cpp <https://reviews.apache.org/r/30074/#comment121926> No need for your else clause when you end the previous block with a return src/tests/slave_tests.cpp <https://reviews.apache.org/r/30074/#comment121923> Why this change? - Niklas Nielsen On Feb. 19, 2015, 1:03 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 1:03 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos > > > Description > ------- > > Adds and entry `max_allowed_age_secs` to the response of the `state.json` > endpoint in the slave. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.StateEndpoint` so it takes into account the > new entry. > > > Diffs > ----- > > src/slave/metrics.hpp e2ce845ec2229e1e6e71c710022551bec9d15029 > src/slave/metrics.cpp ee610b8a7d352c20e8a91bb86c8aa2c1f011e910 > src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 > src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 > src/tests/slave_tests.cpp 21709e2858d91a2746e0343786f73dec22735da6 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
