> On March 3, 2015, 10:37 p.m., Ben Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 19-23 > > <https://reviews.apache.org/r/31701/diff/1/?file=883404#file883404line19> > > > > Can you put the .h includes first? It looks like we've become > > inconsistent on this unfortunately, but it looks like we've been putting > > them first on most of the core test files. I'm also not sure if we want to > > have to guess that some .h's are C++ and so they belong futher down than > > other h's.
Reverted. > On March 3, 2015, 10:37 p.m., Ben Mahler wrote: > > src/tests/resource_offers_tests.cpp, lines 19-23 > > <https://reviews.apache.org/r/31701/diff/1/?file=883405#file883405line19> > > > > Ditto, mind leaving this as it was? Reverted - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31701/#review75069 ----------------------------------------------------------- On March 3, 2015, 8:13 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31701/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 8:13 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Moved task validation tests to master_validation_tests.cpp. > > This is a pure code movement. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > 38ddb1dae2298e3cb3dddb82a8b32e8610133d97 > src/tests/resource_offers_tests.cpp > d1eb2fcb064e520d0ddf7685e550ca6680327680 > > Diff: https://reviews.apache.org/r/31701/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
