----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31724/#review75190 -----------------------------------------------------------
This looks like a bug in the current code because `INADDR_LOOPBACK == 0x7f000001 == 2130706433` and `htonl(INADDR_LOOPBACK) != INADDR_LOOPBACK`. Could you please file a ticket first? Thanks! 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/31724/#comment122165> Please fix the indentation here. - Jie Yu On March 4, 2015, 12:45 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31724/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 12:45 p.m.) > > > Review request for mesos, Dominic Hamon and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Replace hardcoded constants from libprocess with INADDR_ANY and > INADDR_LOOPBACK > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 6f9a0d290de6838c20d208266b670999186e1798 > > Diff: https://reviews.apache.org/r/31724/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
