----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31734/#review75215 -----------------------------------------------------------
Ship it! src/messages/log.hpp <https://reviews.apache.org/r/31734/#comment122181> Looks like just <ostream> will suffice? src/messages/messages.hpp <https://reviews.apache.org/r/31734/#comment122180> Do you still need this include? src/messages/messages.hpp <https://reviews.apache.org/r/31734/#comment122182> Not yours, but looks like we need an <ostream> include. - Ben Mahler On March 4, 2015, 7:06 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31734/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 7:06 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Kapil Arya. > > > Bugs: MESOS-2447 > https://issues.apache.org/jira/browse/MESOS-2447 > > > Repository: mesos > > > Description > ------- > > Fixed a regression of replicated log logging. > > > Diffs > ----- > > src/messages/log.hpp b9c1dabce1f2755d7757b6da862457aff733f152 > src/messages/messages.hpp 4333b90310d59f4b9b1c628b11197b3aaa9b1508 > > Diff: https://reviews.apache.org/r/31734/diff/ > > > Testing > ------- > > Manually verify the logging. > > Before: > Replica learned 2 action at position 3 > > After: > Replica learned APPEND action at position 3 > > > Thanks, > > Jie Yu > >
