----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31700/#review75230 -----------------------------------------------------------
src/master/http.cpp <https://reviews.apache.org/r/31700/#comment122194> Let's keep the .reserve() optimization very explicit, can you just use `.reserve()` explicitly here and elsewhere? It would be helpful to have `"// MESOS-2353"` as a trailing comment on the reserve calls as well. src/master/http.cpp <https://reviews.apache.org/r/31700/#comment122195> Please revert this one, it's not related to state.json, we're not expecting there to be a lot of frameworks, and copying a pointer is not expensive. This is why benchmarks are nice :) - Ben Mahler On March 3, 2015, 8:11 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31700/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 8:11 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2353 > https://issues.apache.org/jira/browse/MESOS-2353 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07 > > Diff: https://reviews.apache.org/r/31700/diff/ > > > Testing > ------- > > make check (OS X 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
