----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31702/#review75265 -----------------------------------------------------------
Ship it! src/tests/master_validation_tests.cpp <https://reviews.apache.org/r/31702/#comment122231> Mind adding a comment about why you're doing this? Also, could the resume() be replaced with settle()? Otherwise this test may become slow it if relies on the allocation interval time elapsing. src/tests/mesos.hpp <https://reviews.apache.org/r/31702/#comment122229> Include vector? src/tests/mesos.hpp <https://reviews.apache.org/r/31702/#comment122230> Include foreach? - Ben Mahler On March 4, 2015, 11:47 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31702/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 11:47 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Moved and re-enabled a persistent volume test. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > 38ddb1dae2298e3cb3dddb82a8b32e8610133d97 > src/tests/mesos.hpp e91e5e484eea4587ac8f2eb9cefeab4acc9f4615 > src/tests/persistent_volume_tests.cpp > e739cf520040ec1db822d46202b803834370baab > > Diff: https://reviews.apache.org/r/31702/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
