> On March 6, 2015, 6:38 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/process.cpp, line 837 > > <https://reviews.apache.org/r/29289/diff/24/?file=887418#file887418line837> > > > > Please do not remove any logging. > > > > ``` > > LOG(FATAL) << "Parsing LIBPROCESS_IP=" << value << " failed: " << > > ip.error(); > > ``` > > > > `ip.isError()` is a boolean, are you going to print a boolean when the > > parsing fails?
sorry for that. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/#review74860 ----------------------------------------------------------- On March 6, 2015, 5:16 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29289/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 5:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > e55147ae535b2b27271b69da3db7aff6cd202368 > 3rdparty/libprocess/include/process/address.hpp > f5fb4dd2fdeaade36390c083bee6f2787df4b6d3 > 3rdparty/libprocess/include/process/network.hpp > 7620278e4b2c376e37353325aa717fe54b819272 > 3rdparty/libprocess/include/process/pid.hpp > 30c466c8defb45bbfaaf68611fb68285a89fea6e > 3rdparty/libprocess/include/process/socket.hpp > 2c4258775bd90f91f1922a3cf2bb4ddf5c334881 > 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915 > 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd > 3rdparty/libprocess/src/poll_socket.cpp > ec781a3ac0a245831c679826c97045fd3a2b4656 > 3rdparty/libprocess/src/process.cpp > 671aff6692be4ec49f7af4851a0511c178e58b45 > 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 > 3rdparty/libprocess/src/tests/http_tests.cpp > 0a00ae59fe999344eb05bee04ab3fb703a3265e7 > 3rdparty/libprocess/src/tests/process_tests.cpp > eb38edce2c483ba7f963a826893a15a075238618 > > Diff: https://reviews.apache.org/r/29289/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
