----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31538/#review75582 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/31538/#comment122770> This no longer applies, so how about // Failing this validation on the executor driver // used to cause the driver to abort. Now that the // validation is done by the slave, it should // shutdown the executor to be consistent. // TODO(arojas): Once the HTTP API is the default, return a // 400 Bad Request response, indicating the reason in the body. src/slave/slave.cpp <https://reviews.apache.org/r/31538/#comment122772> ``` LOG(ERROR) << "Received TASK_STAGING from executor << executor->id << " of framework " << update.framework_id() << " which is not allowed; Shutting down the executor"; shutdownExecutor(framework, executor); ``` - Vinod Kone On March 6, 2015, 10:42 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31538/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 10:42 a.m.) > > > Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone. > > > Bugs: mesos-2291 > https://issues.apache.org/jira/browse/mesos-2291 > > > Repository: mesos > > > Description > ------- > > Copies validations made to the messages exchanged between the slave and the > `MesosExecutorDriver` and performed in the executor driver to the slave. This > is requiered since the new HTTP API will deprecate the executor driver. > > > Diffs > ----- > > src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 > src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c > > Diff: https://reviews.apache.org/r/31538/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
