> On March 6, 2015, 11:09 p.m., Alexander Rukletsov wrote: > > src/master/allocator/sorter/drf/sorter.hpp, line 89 > > <https://reviews.apache.org/r/31667/diff/3/?file=883431#file883431line89> > > > > `SlaveID` as a function parameter?
Are you suggesting adding `SlaveID` to this function? or are you suggesting adding a `virtual Resources allocation(const std::string& name, const SlaveID& slaveId);`? If former, we actually use this form of `allocation` in `removeFramework`. If latter, we would have to justify the performance benefit or have a good reason why it should be in the `Sorter` API. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/#review75561 ----------------------------------------------------------- On March 3, 2015, 8:29 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31667/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 8:29 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-2373 > https://issues.apache.org/jira/browse/MESOS-2373 > > > Repository: mesos > > > Description > ------- > > `Sorter` changes: > > - Augmented `add`, `remove`, `allocated`, `unallocated`, `update` with > `SlaveID`. > - `allocation` returns `hashmap<SlaveID, Resources>`. > > `DRFSorter` changes: > > - `allocations` is updated from `hashmap<std::string, Resources>` to > `hashmap<std::string, hashmap<SlaveID, Resources>>`. > - `resources` is updated from `Resources` to `hashmap<SlaveID, Resources>`. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > c0b1da75565d9dc7728c5566f01815234163fc47 > src/master/allocator/sorter/drf/sorter.hpp > 4366710d6530b784aa5094813328d0e338239ba0 > src/master/allocator/sorter/drf/sorter.cpp > 2f69f384b95ff20d3ee429a4570a8cffa74d8e8b > src/master/allocator/sorter/sorter.hpp > e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b > src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd > > Diff: https://reviews.apache.org/r/31667/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
