> On March 9, 2015, 10:46 p.m., Cong Wang wrote: > > src/linux/routing/filter/ip.hpp, line 202 > > <https://reviews.apache.org/r/31870/diff/1/?file=889627#file889627line202> > > > > Since what you expose is the generic Filter, this API should be in > > filter/filter.hpp instead of filter/ip.hpp, even though we only read IP > > filters in my case.
This is intentional so that the callsites read well: ``` xxx = ip::filters(); ``` Otherwise (i.e., expose it in filter.hpp), we have to do: ``` xxx = filters<ip::Classifiers>(); ``` , which is a little bit hard to read. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31870/#review75802 ----------------------------------------------------------- On March 9, 2015, 8:54 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31870/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 8:54 p.m.) > > > Review request for mesos, Chi Zhang and Cong Wang. > > > Repository: mesos > > > Description > ------- > > Added an interface to get all IP packet filters. > > > Diffs > ----- > > src/linux/routing/filter/filter.hpp > 194703fb8f89bdac7cd95b066cb132d8947701a3 > src/linux/routing/filter/ip.hpp 0d1dd5013e27f82550962be11eac103a8b87023e > src/linux/routing/filter/ip.cpp 9d8639b744e6f54cabaa9c866c02fec83dbcdbfa > > Diff: https://reviews.apache.org/r/31870/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
