> On March 9, 2015, 9:51 p.m., Joerg Schad wrote: > > src/common/type_utils.cpp, line 59 > > <https://reviews.apache.org/r/31784/diff/2/?file=887439#file887439line59> > > > > From my understanding this will cause errors as environment does not > > have a default value and hence we should check before whether it is present > > (see https://code.google.com/p/protobuf-c/wiki/Default_Values).
retracted. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31784/#review75793 ----------------------------------------------------------- On March 6, 2015, 6:04 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31784/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 6:04 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joerg Schad, Till Toenshoff, > Vinod Kone, and Zameer Manji. > > > Bugs: mesos-2309 > https://issues.apache.org/jira/browse/mesos-2309 > > > Repository: mesos > > > Description > ------- > > type_utils: Relaxened the equality check of CommandInfo to allow 'unset' > environment == 'empty' environment. > > > Diffs > ----- > > src/Makefile.am d299f07d865080676ca8a550cf6005c6ab32839f > src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 > src/tests/type_utils_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31784/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
