They should have supported # numbered lists or something other than using "1." for each item, as that reads poorly. We should optimize for readable numbered lists as opposed to diffs, is there another way to let the numbers be computed implicitly? If not, let's just number correctly to be consistent with the rest of our markdown (let me know if we haven't actually been doing this).
On Sat, Mar 7, 2015 at 3:27 PM, Aaron Bell <[email protected]> wrote: > > > > On March 6, 2015, 7:28 p.m., Ben Mahler wrote: > > > docs/release-guide.md, lines 148-151 > > > < > https://reviews.apache.org/r/31720/diff/2/?file=884496#file884496line148> > > > > > > Could we please number these correctly? > > Hi Ben - just checking, are you aware of the advantages of this valid > Markdown feature? > Numbered in the way you suggest, adding a new item in position #1 of a > list will force a change on every subsequent line (since you have to bump > all the numbers). This style allows much cleaner diffs on ordered lists. > > > - Aaron > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31720/#review75531 > ----------------------------------------------------------- > > > On March 4, 2015, 8:06 p.m., Aaron Bell wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/31720/ > > ----------------------------------------------------------- > > > > (Updated March 4, 2015, 8:06 p.m.) > > > > > > Review request for mesos and Niklas Nielsen. > > > > > > Bugs: MESOS-2448 > > https://issues.apache.org/jira/browse/MESOS-2448 > > > > > > Repository: mesos > > > > > > Description > > ------- > > > > MESOS-2448 add homebrew update to release guide > > > > > > Diffs > > ----- > > > > docs/release-guide.md a016861 > > > > Diff: https://reviews.apache.org/r/31720/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Aaron Bell > > > > > >
