----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review76119 -----------------------------------------------------------
3rdparty/libprocess/src/openssl.cpp <https://reviews.apache.org/r/29406/#comment123548> Use the verify flag correctly. Currently it is being ignored and we always verify the cert if provided. - Joris Van Remoortere On Feb. 20, 2015, 7:24 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29406/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 7:24 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1913 > https://issues.apache.org/jira/browse/MESOS-1913 > > > Repository: mesos > > > Description > ------- > > Requires: > configure --enable-libevent --enable-libevent-socket --enable-ssl > New environment variables: > USE_SSL=(0,1) > SSL_CERT=(path to certificate) > SSL_KEY=(path to key) > SSL_VERIFY_CERT=(0,1) > SSL_REQUIRE_CERT=(0,1) > SSL_CA_DIR=(path to CA directory) > SSL_CA_FILE=(path to CA file) > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9 > 3rdparty/libprocess/include/process/socket.hpp > ddb9e365fc1e65a568bdac4973964df1ab8cc05e > 3rdparty/libprocess/src/libevent.hpp > f6cc72178613a30446629532a773afccfd404212 > 3rdparty/libprocess/src/libevent.cpp > 28c2cf7f49cc153158f2a470a1812e35f7d4b93a > 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION > 3rdparty/libprocess/src/openssl.hpp PRE-CREATION > 3rdparty/libprocess/src/openssl.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf > 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f > > Diff: https://reviews.apache.org/r/29406/diff/ > > > Testing > ------- > > make check (uses non-ssl socket) > benchmarks using ssl sockets > master, slave, framework, webui launch with ssl sockets > > > Thanks, > > Joris Van Remoortere > >
