----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31889/#review76079 -----------------------------------------------------------
One high-level note: Let's get the long lived executor test wired up so we can verify this fix. include/mesos/hook.hpp <https://reviews.apache.org/r/31889/#comment123479> This is a public API; let's defer this todo to a JIRA if we plan to do something about it src/examples/test_hook_module.cpp <https://reviews.apache.org/r/31889/#comment123480> This fits on one line. I know that we do this differently for CHECK() but for LOG(XXXYYZZ) we align as we did before. src/examples/test_hook_module.cpp <https://reviews.apache.org/r/31889/#comment123482> Mind adding a TODO about that we need to synchronize the test with this code to make the broken hook test work? src/hook/manager.hpp <https://reviews.apache.org/r/31889/#comment123485> Do we need to pass the 'set' environment? I think the API would be cleaner if we only talked about environment variables in terms of the Environment proto. src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123487> Can you expand a bit on how it tests the hook? src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123486> A newline here - Niklas Nielsen On March 10, 2015, 7:15 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31889/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 7:15 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-2463 > https://issues.apache.org/jira/browse/MESOS-2463 > > > Repository: mesos > > > Description > ------- > > The ExecutorInfo is immutable, and so the environment decoration is deferred > until containerizer launch. The new slaveExecutorHook simply notifies the hook > module of a new executor being launched. The environment decorator hook for > containerizer launch update it's environment variables as gathered from the > hook > modules. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d > src/hook/manager.hpp d3729eaca1bf2893cbc94cf62835dafb2d9a22a1 > src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7 > src/slave/containerizer/containerizer.cpp > 33f8738fa229b42ebacfd75b762c977b33191b65 > src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 > src/tests/hook_tests.cpp f4b4f519456dc00a8894c7ce154b28a7ab9ce493 > > Diff: https://reviews.apache.org/r/31889/diff/ > > > Testing > ------- > > make check. The master failover tests have not been performed yet. > > > Thanks, > > Kapil Arya > >
