----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review76837 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/32150/#comment124509> Do we still need this? src/master/master.cpp <https://reviews.apache.org/r/32150/#comment124510> Should we log here? src/master/validation.cpp <https://reviews.apache.org/r/32150/#comment124504> No period at the end of the error message. Ditto everywhere below. src/master/validation.cpp <https://reviews.apache.org/r/32150/#comment124506> Just to confirm we are on the same page: an operator cannot reserve resources for a framework directly, they can only reserve resources for a role, correct? - Alexander Rukletsov On March 17, 2015, 4:06 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32150/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 4:06 a.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2139 > https://issues.apache.org/jira/browse/MESOS-2139 > > > Repository: mesos > > > Description > ------- > > Handled reservation operations in `Master::_accept`. > > Added `validate` functions in `src/master/validation.{hpp,cpp}`. > > > Diffs > ----- > > src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 > src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec > src/master/validation.cpp 2f2e4ea8ea123c5a0d01446cdec8b308ea60932e > > Diff: https://reviews.apache.org/r/32150/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
