Re: Review Request 32233: Replaced raw pointer by Owned pointer

[Bernd Mathiske]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77012
-----------------------------------------------------------



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124770>

    Put each parameter on a new line if they don't all fit in one:
    
        return dispatch(process.get(),
                        &ExternalContainerizerProcess::recover,
                        state);



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124769>

    Align the parameters like this:
    
        return dispatch(process.get(),                        
                        &ExternalContainerizerProcess::launch,
                        containerId,
                        None(),
                        executorInfo,
                        directory,



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124771>

    Align parameters.



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124773>

    Align parameters.



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124774>

    1 param per line



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124775>

    1 param per line



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124776>

    1 param per line


- Bernd Mathiske


On March 18, 2015, 9:14 p.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 9:14 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 
> 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 
> 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>