> On March 19, 2015, 6:06 p.m., Ben Mahler wrote: > > Interesting change cody? Are you still looking to get this in? > > > > I'm hoping we can clean up the current design of http::get and http::post, > > where the function arguments have essentially grown to be subsets of things > > inside the 'Request' object. This seems like a first step towards that, > > what was your plan for http::get and http::post?
I'd definitely like to get this series leading to the reverse proxy endpoint in / landed in the future. I don't have development cycles to give it at the moment though. If you'd like to pick up the patch in the meantime feel free to. I definitely think there are soo many parametric options here, a default-constructed object (Soon we can even use member initializers!) + helper functions to set from specialized different forms (Query string -> query map), would be nice. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28254/#review77073 ----------------------------------------------------------- On Nov. 20, 2014, 12:54 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28254/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 12:54 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-2132 > https://issues.apache.org/jira/browse/MESOS-2132 > > > Repository: mesos > > > Description > ------- > > libprocess gives HTTP Handlers a Request object. If one of those handlers > wants to act as a proxy and forward all/part of that request across the > network, it currently has to split up the object it is given, manually encode > the query string, and then call either http::get() or http::post() (Other > HTTP methods aren't supported). > > Adds a general mechanism for forwarding requests to remote nodes (IP/Port) > pairs and getting back the response. > > Cleans up some right angle brackets as a drive-by fix. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 9cf05acbb724ab9af8010d1788621d37a0e48e86 > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > > Diff: https://reviews.apache.org/r/28254/diff/ > > > Testing > ------- > > make distcheck ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
