+1 (binding) We have deployed something *close* to rc4 to production, I've shown how they diverge below. You may want to further scrutinize the code related patches that differ.
*$* git lol 0.22.0-rc4 DEPLOYED * e890e24 (*tag: 0.22.0-rc4*) Ensured TaskStatus::source field is set for executor status updates. * 7638f82 Add doc for slave_removal_rate_limit. * bf7e77a Used LDADD to add unbundled libraries to all command line programs. * 391e72b Updated Hooks to fix failure during master failover. * cb3278e Fixed a bug in PosixDiskIsolator during slave recovery. * 3477e0f Fixed a regression of replicated log logging. * 5da18be Fixed signed unsigned comparison in fetcher tests. * 1d2e2d2 Fixed race in getFieldID helper. * 3f826e4 Fixed the broken build on OS X 10.8.5. * 5be5d02 Added discovery info documentation. * 4178536 Added user doc for the posix disk isolator. * 98c5791 Reenabled hadoop_home and frameworks_home slave flags for mesos-fetcher. * 88a93a7 Fixed a flaky reconciliation test. * 7f973b5 Put Authentication protobufs back in mesos.internal package. * 66a70de Updated configuration doc. * 0c9cc0c Updated the upgrade guide. * 0e2f9e9 Updated changelog for 0.22.0. | * 005f80d (*tag: DEPLOYED*) *** Cherrypicked *** Removed executor environment decoration. | * b0e624f Fixed a bug in PosixDiskIsolator during slave recovery. | * a6d5a2e Fixed a bug in the log benchmark tool. | * 8eafbf4 Fixed a regression of replicated log logging. | * 25db072 *** Cherrypicked *** Send TASK_LOST instead of TASK_ERROR due to AURORA-1001. | * ba27d43 Put Authentication protobufs back in mesos.internal package. |/ * 46834fa (*tag: 0.22.0-rc1*) Fixed the compilation issue in port mapping tests. The "sudo" test failures are not ideal, if you want to create an RC5 with them disabled that would be ok but not necessary IMO. I'd suggest leaving them in but when we do 0.22.1 or 0.23.0 we should try to anticipate and fix/disable any failing tests. On Mon, Mar 23, 2015 at 1:59 PM, Benjamin Mahler <[email protected]> wrote: > Don't think these are blockers, but they do consistently fail for me. > > The perf failures seem to have been captured alongside other failures for > 0.21.1 in MESOS-2300 <https://issues.apache.org/jira/browse/MESOS-2300>. > > According to vinod, the MesosContainerizerDestroyTest.DestroyWhileFetching > failure is the same issue as the failure in MESOS-2402 > <https://issues.apache.org/jira/browse/MESOS-2402>. > > For the UserCgroupIsolatorTest failures, I've filed MESOS-2532 > <https://issues.apache.org/jira/browse/MESOS-2532>. > > > > On Sun, Mar 22, 2015 at 2:12 PM, Niklas Nielsen <[email protected]> > wrote: > >> Did you file a JIRA for the broken test? >> >> Niklas >> >> On 21 March 2015 at 13:29, Benjamin Mahler <[email protected]> >> wrote: >> >> > On CentOS w/ gcc 4.8, "make check" passes but "sudo make check" fails >> for >> > me: >> > >> > [ RUN ] PerfTest.ROOT_SampleInit >> > ../../src/tests/perf_tests.cpp:147: Failure >> > Expected: (0u) < (statistics.get().cycles()), actual: 0 vs 0 >> > ../../src/tests/perf_tests.cpp:150: Failure >> > Expected: (0.0) < (statistics.get().task_clock()), actual: 0 vs 0 >> > [ FAILED ] PerfTest.ROOT_SampleInit (1076 ms) >> > >> > [----------] 1 test from UserCgroupIsolatorTest/0, where TypeParam = >> > mesos::internal::slave::CgroupsMemIsolatorProcess >> > userdel: user mesos.test.unprivileged.user does not exist >> > [ RUN ] UserCgroupIsolatorTest/0.ROOT_CGROUPS_UserCgroup >> > ../../src/tests/isolator_tests.cpp:1067: Failure >> > (isolator.get()->prepare( containerId, executorInfo, os::getcwd(), >> > UNPRIVILEGED_USERNAME)).failure(): Failed to prepare isolator: cgroup >> > already exists >> > [ FAILED ] UserCgroupIsolatorTest/0.ROOT_CGROUPS_UserCgroup, where >> > TypeParam = mesos::internal::slave::CgroupsMemIsolatorProcess (19 ms) >> > [----------] 1 test from UserCgroupIsolatorTest/0 (19 ms total) >> > >> > [----------] 1 test from UserCgroupIsolatorTest/1, where TypeParam = >> > mesos::internal::slave::CgroupsCpushareIsolatorProcess >> > userdel: user mesos.test.unprivileged.user does not exist >> > [ RUN ] UserCgroupIsolatorTest/1.ROOT_CGROUPS_UserCgroup >> > ../../src/tests/isolator_tests.cpp:1067: Failure >> > (isolator.get()->prepare( containerId, executorInfo, os::getcwd(), >> > UNPRIVILEGED_USERNAME)).failure(): Failed to prepare isolator: cgroup >> > already exists >> > [ FAILED ] UserCgroupIsolatorTest/1.ROOT_CGROUPS_UserCgroup, where >> > TypeParam = mesos::internal::slave::CgroupsCpushareIsolatorProcess (10 >> ms) >> > [----------] 1 test from UserCgroupIsolatorTest/1 (10 ms total) >> > >> > [----------] 1 test from UserCgroupIsolatorTest/2, where TypeParam = >> > mesos::internal::slave::CgroupsPerfEventIsolatorProcess >> > userdel: user mesos.test.unprivileged.user does not exist >> > [ RUN ] UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup >> > ../../src/tests/isolator_tests.cpp:1067: Failure >> > (isolator.get()->prepare( containerId, executorInfo, os::getcwd(), >> > UNPRIVILEGED_USERNAME)).failure(): Failed to prepare isolator: cgroup >> > already exists >> > [ FAILED ] UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup, where >> > TypeParam = mesos::internal::slave::CgroupsPerfEventIsolatorProcess (18 >> ms) >> > [----------] 1 test from UserCgroupIsolatorTest/2 (18 ms total) >> > >> > Also this test has a stack trace but is still passing, not sure if >> that's >> > expected? >> > >> > [ RUN ] MesosContainerizerDestroyTest.DestroyWhileFetching >> > ABORT: (../../../3rdparty/libprocess/src/subprocess.cpp:165): Failed to >> > os::execvpe in childMain >> > *** Aborted at 1426968960 (unix time) try "date -d @1426968960" if you >> are >> > using GNU date *** >> > PC: @ 0x7f7704a6ffc5 __GI_raise >> > *** SIGABRT (@0x4ba2) received by PID 19362 (TID 0x7f76fdd11940) from >> PID >> > 19362; stack trace: *** >> > @ 0x7f7705737ca0 (unknown) >> > @ 0x7f7704a6ffc5 __GI_raise >> > @ 0x7f7704a71a70 __GI_abort >> > @ 0x8f643b _Abort() >> > @ 0x7f7708ef75ba process::childMain() >> > @ 0x7f7708efc3da >> > >> > >> _ZNSt5_BindIFPFiRKSsPPcRKN7process10Subprocess2IOES8_S8_PN2os7ExecEnvERK6OptionISt8functionIFivEEEPiSJ_SJ_ESsS3_S6_S6_S6_SB_SG_SJ_SJ_SJ_EE6__callIiJEJLm0ELm1ELm2ELm3ELm4ELm5ELm6ELm7ELm8ELm9EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE >> > @ 0x7f7708efba28 >> > >> > >> _ZNSt5_BindIFPFiRKSsPPcRKN7process10Subprocess2IOES8_S8_PN2os7ExecEnvERK6OptionISt8functionIFivEEEPiSJ_SJ_ESsS3_S6_S6_S6_SB_SG_SJ_SJ_SJ_EEclIJEiEET0_DpOT_ >> > @ 0x7f7708efb05c std::_Function_handler<>::_M_invoke() >> > [ OK ] MesosContainerizerDestroyTest.DestroyWhileFetching (79 ms) >> > >> > On Thu, Mar 19, 2015 at 2:18 PM, Alex Rukletsov <[email protected]> >> > wrote: >> > >> > > +1 (non-binding) >> > > >> > > Mac OS 10.9.5 + clang >> > > CentOS 7 + gcc 4.4.7 [cgroups tests disabled] >> > > >> > > On Wed, Mar 18, 2015 at 4:04 PM, Brenden Matthews < >> [email protected]> >> > > wrote: >> > > >> > >> +1 >> > >> >> > >> Tested with internal testing cluster. >> > >> >> > >> On Wed, Mar 18, 2015 at 1:25 PM, craig w <[email protected]> >> wrote: >> > >> >> > >>> +1 >> > >>> >> > >>> On Wed, Mar 18, 2015 at 3:52 PM, Niklas Nielsen < >> [email protected]> >> > >>> wrote: >> > >>> >> > >>>> Hi all, >> > >>>> >> > >>>> Please vote on releasing the following candidate as Apache Mesos >> > 0.22.0. >> > >>>> >> > >>>> >> > >>>> 0.22.0 includes the following: >> > >>>> >> > >>>> >> > >> -------------------------------------------------------------------------------- >> > >>>> >> > >>>> * Support for explicitly sending status updates acknowledgements >> from >> > >>>> schedulers; refer to the upgrades document for upgrading >> schedulers. >> > >>>> * Rate limiting slave removal, to safeguard against unforeseen bugs >> > >>>> leading to >> > >>>> widespread slave removal. >> > >>>> * Disk quota isolation in Mesos containerizer; refer to the >> > >>>> containerization >> > >>>> documentation to enable disk quota monitoring and enforcement. >> > >>>> * Support for module hooks in task launch sequence. Refer to the >> > modules >> > >>>> documentation for more information. >> > >>>> * Anonymous modules: a new kind of module that does not receive any >> > >>>> callbacks >> > >>>> but coexists with its parent process. >> > >>>> * New service discovery info in task info allows framework users to >> > >>>> specify >> > >>>> discoverability of tasks for external service discovery systems. >> > >>>> Refer to >> > >>>> the framework development guide for more information. >> > >>>> * New '--external_log_file' flag to serve external logs through the >> > >>>> Mesos web UI. >> > >>>> * New '--gc_disk_headroom' flag to control maxmimum executor >> sandbox >> > >>>> age. >> > >>>> >> > >>>> >> > >>>> The CHANGELOG for the release is available at: >> > >>>> >> > >>>> >> > >> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.22.0-rc4 >> > >>>> >> > >>>> >> > >> -------------------------------------------------------------------------------- >> > >>>> >> > >>>> The candidate for Mesos 0.22.0 release is available at: >> > >>>> >> > >>>> >> > >> https://dist.apache.org/repos/dist/dev/mesos/0.22.0-rc4/mesos-0.22.0.tar.gz >> > >>>> >> > >>>> The tag to be voted on is 0.22.0-rc4: >> > >>>> >> > >>>> >> > >> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.22.0-rc4 >> > >>>> >> > >>>> The MD5 checksum of the tarball can be found at: >> > >>>> >> > >>>> >> > >> https://dist.apache.org/repos/dist/dev/mesos/0.22.0-rc4/mesos-0.22.0.tar.gz.md5 >> > >>>> >> > >>>> The signature of the tarball can be found at: >> > >>>> >> > >>>> >> > >> https://dist.apache.org/repos/dist/dev/mesos/0.22.0-rc4/mesos-0.22.0.tar.gz.asc >> > >>>> >> > >>>> The PGP key used to sign the release is here: >> > >>>> https://dist.apache.org/repos/dist/release/mesos/KEYS >> > >>>> >> > >>>> The JAR is up in Maven in a staging repository here: >> > >>>> >> > https://repository.apache.org/content/repositories/orgapachemesos-1048 >> > >>>> >> > >>>> Please vote on releasing this package as Apache Mesos 0.22.0! >> > >>>> >> > >>>> The vote is open until Sat Mar 21 12:49:56 PDT 2015 and passes if a >> > >>>> majority of at least 3 +1 PMC votes are cast. >> > >>>> >> > >>>> [ ] +1 Release this package as Apache Mesos 0.22.0 >> > >>>> [ ] -1 Do not release this package because ... >> > >>>> >> > >>>> Thanks, >> > >>>> Niklas >> > >>>> >> > >>> >> > >>> >> > >>> >> > >>> -- >> > >>> >> > >>> https://github.com/mindscratch >> > >>> https://www.google.com/+CraigWickesser >> > >>> https://twitter.com/mind_scratch >> > >>> https://twitter.com/craig_links >> > >>> >> > >>> >> > >> >> > > >> > >> > >
