> On March 19, 2015, 6:03 p.m., Jie Yu wrote: > > src/Makefile.am, line 1284 > > <https://reviews.apache.org/r/31276/diff/5/?file=899169#file899169line1284> > > > > Can you remind me why this is needed? Looks like it's already in > > mesos_tests_SOURCES?
uses tests/flags.cpp to spawn the subprocess in MHT. still need mesos_tests_CPPFLAGS because the BUILD_DIR macro is needed for flags.build_dir > On March 19, 2015, 6:03 p.m., Jie Yu wrote: > > src/tests/memory_test_helper.cpp, lines 215-219 > > <https://reviews.apache.org/r/31276/diff/5/?file=899172#file899172line215> > > > > s/terminate/cleanup/ > > > > Let's make that a private member funciton of MemoryTestHelper so that > > you can get the subprocess directly without passing in the pid. > > > > ``` > > // NOTE: This function will be blocked until the subprocess is reaped. > > void MemoryTestHelper::cleanup() > > { > > if (s.isSome()) { > > kill(s.get().pid(), SIGKILL); > > reap(s.get().pid()).await(); > > s = None(); > > } > > } > > ``` added a public cleanup, as discussed, to leave room for user to explictly control the life time of the subprocess. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31276/#review76978 ----------------------------------------------------------- On March 24, 2015, 10:15 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31276/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 10:15 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: mesos-2136 > https://issues.apache.org/jira/browse/mesos-2136 > > > Repository: mesos > > > Description > ------- > > Added cgroup memory pressure listening tests. > > > Diffs > ----- > > src/Makefile.am 7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb > src/tests/cgroups_tests.cpp 75c61aad80f894acb92a9752e8d1b6af70e5b9a6 > src/tests/memory_test_helper.hpp PRE-CREATION > src/tests/memory_test_helper.cpp PRE-CREATION > src/tests/memory_test_helper_main.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31276/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
