----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32543/#review78025 -----------------------------------------------------------
Great. It reads well and explains the issue. Just a couple of questions for you. docs/slave-recovery.md <https://reviews.apache.org/r/32543/#comment126411> How about: "Troubleshooting: If tasks are not recovering on slave restart when using systemd" Let's not word it as a bug, but as a configuration issue that can be easily resolved. docs/slave-recovery.md <https://reviews.apache.org/r/32543/#comment126412> Minor: Maybe only link on [KillMode] rather than [default KillMode] docs/slave-recovery.md <https://reviews.apache.org/r/32543/#comment126413> (If the slave does not come back, each executorDriver shuts itself down after $MESOS_RECOVERY_TIMEOUT.) Important question: If an executor is killed, does this systemd mode affect whether its tasks would get killed? docs/upgrades.md <https://reviews.apache.org/r/32543/#comment126410> Is there some new behavior in Mesos 0.22 that just caused this issue to start occurring? Or could this have happened with Mesos 0.21 or earlier with the same systemd default setting? If so, this is not an "upgrade" issue and this note doesn't belong in the upgrades doc. - Adam B On March 26, 2015, 4:53 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32543/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 4:53 p.m.) > > > Review request for mesos, Alexander Rukletsov and Brenden Matthews. > > > Bugs: Mesos-2555 > https://issues.apache.org/jira/browse/Mesos-2555 > > > Repository: mesos > > > Description > ------- > > Document problem and solution encountered in Mesos-2419. > > > Diffs > ----- > > docs/slave-recovery.md 4bb4a71c6945bd70121743a1e9209a26906773c1 > docs/upgrades.md 2a15694607c079ad95ef6cf7f1490872ab9a5976 > > Diff: https://reviews.apache.org/r/32543/diff/ > > > Testing > ------- > > markdown check > > > Thanks, > > Joerg Schad > >
