> On March 24, 2015, 2:49 p.m., Michael Park wrote:
> > src/tests/master_allocator_tests.cpp, lines 123-126
> > <https://reviews.apache.org/r/31268/diff/4/?file=903030#file903030line123>
> >
> > Could we indent this similar to this example from
> > `src/tests/isolator_tests.cpp`:
> >
> > ```
> > typedef ::testing::Types<
> > CgroupsMemIsolatorProcess,
> > CgroupsCpushareIsolatorProcess,
> > CgroupsPerfEventIsolatorProcess> CgroupsIsolatorTypes;
> > ```
> >
> > ```
> > typedef ::testing::Types<
> > HierarchicalDRFAllocator,
> > tests::Module<Allocator, TestDRFAllocator>> AllocatorTypes;
> > ```
>
> Alexander Rukletsov wrote:
> I don't know what is consistent here,
> `src/tests/cram_md5_authentication_tests.cpp` use the indentation I use.
> Also, clang-format gives something that is more similar to the way I propose.
Yeah I did see the one from `src/tests/cram_md5_authentication_tests.cpp`.
I think that one is long enough that we can't do too much better.
I would prefer a style that visually separates the list of types with the
resulting type.
`clang-format` seems to format it as:
```
typedef ::testing::Types<HierarchicalDRFAllocator,
tests::Module<Allocator, TestDRFAllocator>>
AllocatorTypes;
```
which also visually separates the list of types and the resulting type so I'm
ok with that also.
Just explaining exactly what I was pushing for. Having said that, do whatever
you feel is right here :)
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31268/#review77572
-----------------------------------------------------------
On March 27, 2015, 4:27 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31268/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 4:27 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Same typed tests are used for built-in and modularized allocators.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp
> 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302
>
> Diff: https://reviews.apache.org/r/31268/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
