> On March 27, 2015, 6:51 p.m., Benjamin Hindman wrote: > > src/java/jni/org_apache_mesos_state_AbstractState.cpp, line 249 > > <https://reviews.apache.org/r/32152/diff/4/?file=907011#file907011line249> > > > > Can we confirm that we can make a jclass be static? > > Michael Park wrote: > I believe this can't be made `static` unless we make it a global like so: > ``` > static jclass clazz = > (jclass)env->NewGlobalRef(env->GetObjectClass(thiz)); > ``` > I think it's the same situation as: > [MESOS-2414](https://issues.apache.org/jira/browse/MESOS-2414).
Indeed we can not. Using Mpark's strategy. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32152/#review78092 ----------------------------------------------------------- On March 27, 2015, 10:43 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32152/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 10:43 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1795 and MESOS-2161 > https://issues.apache.org/jira/browse/MESOS-1795 > https://issues.apache.org/jira/browse/MESOS-2161 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_state_AbstractState.cpp > 1accc8a498a68b7cfd9e39dc1f3ce01c8bfd219f > src/java/src/org/apache/mesos/state/AbstractState.java > c66bf0519e7fc671d1e167ccd1e778dc65d3d8e6 > > Diff: https://reviews.apache.org/r/32152/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
