> On March 25, 2015, 1:01 a.m., Isabel Jimenez wrote: > > 3rdparty/libprocess/src/http.cpp, line 20 > > <https://reviews.apache.org/r/32336/diff/1/?file=901879#file901879line20> > > > > I know this was just submitted but just a small question: > > why are we duplicating these includes here?, they are already in the > > .hpp, also can we go further and remove the includes that aren't used? I > > saw you moved some of them on https://reviews.apache.org/r/32338/diff/#, > > could we add something like: > > http://fpaste.org/202390/23788014/raw/
We haven't been relying on transitive includes. How do I know that the header is already using foreach? What if the header stops using foreach? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32336/#review77694 ----------------------------------------------------------- On March 20, 2015, 11:51 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32336/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 11:51 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Many of the other http definitions are already moved to the .cpp file, this > continues that trend. > > Moving them out makes the API a lot more readable from the scanning the > header. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 2b366986b1f617e95bda94e07f2a0e532f5626f6 > 3rdparty/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef > > Diff: https://reviews.apache.org/r/32336/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
