> On March 30, 2015, 2:31 a.m., Adam B wrote: > > Serious concerns about the upgrade path here. Please reconsider.
I forgot to describe that this patch is meant to be merged only after 0.23.0 has shipped with the dependent patches. With that in mind, I would now address the issues. Please feel free to reopen any issues that I might have closed in error. > On March 30, 2015, 2:31 a.m., Adam B wrote: > > src/master/master.cpp, line 2565 > > <https://reviews.apache.org/r/32587/diff/1/?file=908259#file908259line2565> > > > > What if you're sending this to an old-version slave? Shouldn't you fill > > in both in this version, and be able to read from either, before you remove > > the field next version? This patch is meant for the "next" version :-). > On March 30, 2015, 2:31 a.m., Adam B wrote: > > src/slave/slave.cpp, line 1107 > > <https://reviews.apache.org/r/32587/diff/1/?file=908260#file908260line1107> > > > > Not true if receiving from an older master, right? Same as above. > On March 30, 2015, 2:31 a.m., Adam B wrote: > > src/slave/slave.cpp, line 1531 > > <https://reviews.apache.org/r/32587/diff/1/?file=908260#file908260line1531> > > > > Similarly, what if the executor is using a previous libmesos? Please > > continue to fill in both fields. Same as above. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32587/#review78174 ----------------------------------------------------------- On March 31, 2015, 4:30 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32587/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 4:30 p.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-2559 > https://issues.apache.org/jira/browse/MESOS-2559 > > > Repository: mesos > > > Description > ------- > > FrameworkID can be retrieved from RunTaskMessage.framework. > > NOTE: This patch is only to be merged _ONLY_ after all the dependent patches > have shipped, i.e. after 0.23.0 (tracked here: > https://issues.apache.org/jira/browse/MESOS-2561) has released. > > > Diffs > ----- > > src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 > src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 > src/tests/mesos.cpp 11e88330dd50913ab00da79054225d113541e83e > > Diff: https://reviews.apache.org/r/32587/diff/ > > > Testing > ------- > > make check > > TODO: Test for upgrade path. > > > Thanks, > > Kapil Arya > >
