----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32659/#review78426 -----------------------------------------------------------
src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32659/#comment127094> s/connectin/listen/? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32659/#comment127093> Maybe useful to put these three lines up where you explain the specific ranges chosen? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32659/#comment127095> Maybe just kill res? (a style goal of mesos is to avoid one-off variables as long as it doesn't hurt readability too much) src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32659/#comment127096> s/'port'/'validPort'/ ? here and everywhere else in the comments in this file? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32659/#comment127098> src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32659/#comment127103> is this longer than 80 characters? could you check other places? (btw, support/hooks/pre-commit can check for you) src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32659/#comment127106> 2-space indent for line-wrap for assignments. 4-space indent for function definition/invocation http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/ - Chi Zhang On March 31, 2015, 11:11 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32659/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 11:11 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Pull the common container definitions out of PortIsolatorMappingTest for > reuse. > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp f4124c3 > > Diff: https://reviews.apache.org/r/32659/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
