----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review78496 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/32585/#comment127315> Hmm... I was actually thinking that this line of code can be removed now that you're always filling in the id in the FrameworkInfo by the time it gets to the slave. However, upon further inspection I see that there is a Slave::Framework::id field that we'll also need to deprecate, ensuring that Slave::Framework::info.id is set, and thus Archive::Framework::framework_info has the frameworkId. - Adam B On March 31, 2015, 1:29 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32585/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 1:29 p.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-2557 > https://issues.apache.org/jira/browse/MESOS-2557 > > > Repository: mesos > > > Description > ------- > > Framework.id() extracts and returns FrameworkID from Framework.info. > > > Diffs > ----- > > src/master/http.cpp e1a87d646e9690e39a9e84ae383622018ce80401 > src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d > src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 > src/master/validation.cpp 2f2e4ea8ea123c5a0d01446cdec8b308ea60932e > src/slave/http.cpp 5f0c39afd2fe9a89eb1df0052af8ab422306f30e > src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae > src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 > > Diff: https://reviews.apache.org/r/32585/diff/ > > > Testing > ------- > > make check > > TODO: Test for upgrade path. > > > Thanks, > > Kapil Arya > >
