----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/#review78509 -----------------------------------------------------------
Ship it! src/tests/module.cpp <https://reviews.apache.org/r/31267/#comment127331> Much better than the old variant - thanks for pointing this out! - Till Toenshoff On March 27, 2015, 4:26 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31267/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 4:26 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > The test allocator module is a built-in HierarchicalDRFAllocator put in a > module. > > NOTE: Here we add harness code to load the module, tests will be wired up > later in the patch stack. > > > Diffs > ----- > > src/Makefile.am 7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb > src/examples/test_allocator_module.cpp PRE-CREATION > src/tests/module.hpp 65e567f21744d9a2b07b8680d45bcd1ea47f9508 > src/tests/module.cpp b81144f56e94034feecf3a6a4992af078cf60a81 > > Diff: https://reviews.apache.org/r/31267/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0) > > > Thanks, > > Alexander Rukletsov > >
