> On April 1, 2015, 9:15 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 250-263 > > <https://reviews.apache.org/r/32742/diff/1/?file=912733#file912733line250> > > > > ostringstream? > > > > Have you considered just building a set<string> and using > > strings::join("\n", commands) below? Then you don't have to deal with the > > delimiters in the stringstream and the fact that we're left with an extra > > newline at the end as a result.
Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32742/#review78591 ----------------------------------------------------------- On April 1, 2015, 10:39 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32742/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 10:39 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2461 > https://issues.apache.org/jira/browse/MESOS-2461 > > > Repository: mesos > > > Description > ------- > > Added command logging for processes running in slave's cgroup. > > > Diffs > ----- > > src/slave/slave.cpp 0f70ebafb0f5b16c560decc66e22a43a52732d09 > > Diff: https://reviews.apache.org/r/32742/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
