----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78674 -----------------------------------------------------------
Ship it! src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32654/#comment127609> We usually put constructor/destructors after static methods. ``` public: static void SetUpTestCase() { ... } PortMappingIsolatorTest() : hostIP(net::IP(INADDR_ANY)) {} ``` src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32654/#comment127613> hostIPNetwork.get().address() returns an net::IP, why do you need an extra copy constructor? ``` hostIP = hostIPNetwork.get().address(); ``` - Jie Yu On April 1, 2015, 11:07 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32654/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 11:07 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Clean up HostIPNetwork since every use performs the same extract & stringify > operation > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp f4124c3 > > Diff: https://reviews.apache.org/r/32654/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
