----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review79150 -----------------------------------------------------------
Minor suggestions. src/hook/manager.cpp <https://reviews.apache.org/r/30961/#comment128285> Would it make sense to make taskInfo a pass-by-value param, forcing the copy at the call? src/master/master.cpp <https://reviews.apache.org/r/30961/#comment128286> Update comment src/tests/hook_tests.cpp <https://reviews.apache.org/r/30961/#comment128287> s/remove/removed/ s/hook/the hook/ src/tests/hook_tests.cpp <https://reviews.apache.org/r/30961/#comment128288> s/Value/Key/? src/tests/hook_tests.cpp <https://reviews.apache.org/r/30961/#comment128289> Should also verify `EXPECT_EQ(labels_.labels().Get(0).value(), testLabelValue);` - Adam B On April 2, 2015, 2:39 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30961/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 2:39 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d > src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 > src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 > > Diff: https://reviews.apache.org/r/30961/diff/ > > > Testing > ------- > > make check (with modified VerifyMasterLaunchTaskHook test) > > > Thanks, > > Niklas Nielsen > >
