> On April 10, 2015, 1:31 a.m., Cody Maloney wrote:
> > For the approach I'm worried we're going to spend a lot of ASF CI time
> > re-installing all the base dependencies + copying files in / out. Docker
> > _can_ cache those steps and should for the most part, but still more work
> > then not having to check at all. It seems like it would be cleaner to use
> > the script to generate docker images
> > (mesos-build-environment-{centos,ubuntu,...}) which we throw up on docker
> > hub (Or an ASF internal docker registry preferrably), and for the actual
> > jenkins job we just do a:
> > `docker run -v {mesos-checkout}:/mesos -E GTEST_FILTER="" -E CC=clang -E
> > CXX=clang++ mesos-build-environment-centos7 ./bootstrap && ./configure &&
> > make -j8 distcheck`.
> >
> > That also allows random developers to fairly easily spot check what went
> > wrong in ASF by running the command locally.
> >
> > The base install environments shouldn't change often, and we can automate
> > with a second simple job (Run the build-image script with the array of
> > targets we want) on commits to master and push the images to docker hub.
Using pre built docker images hosted on docker hub was definitely one of the
options I considered. I didn't do it mainly because of the supporting
infrastructure needed to maintain such images (scripts/jobs to build them,
upload them, sharing dockerhub credentials, etc). Using those images is mainly
an optimization, because the time to build those images on the fly is not high
(few min) relative to our build times. I'll add a TODO for now.
Note that a developer can still pretty easily repro a ASF CI failure locally by
running this script locally and setting OS and COMPILER env variables .
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33045/#review79620
-----------------------------------------------------------
On April 9, 2015, 11:47 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33045/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 11:47 p.m.)
>
>
> Review request for mesos, Ben Mahler and Cody Maloney.
>
>
> Bugs: MESOS-2233
> https://issues.apache.org/jira/browse/MESOS-2233
>
>
> Repository: mesos
>
>
> Description
> -------
>
> My goal is to replace the miscelleneous Jenkins jobs on ASF with a single
> multi-configuration job whose configuration lies in the repo. This will make
> the CI management much simpler.
>
>
> Diffs
> -----
>
> support/jenkins_build.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33045/diff/
>
>
> Testing
> -------
>
> Tested with a custom job on ASF Jenkins.
>
> https://builds.apache.org/job/vinod-docker-multi/
>
> NOTE: Disabled clang on CentOS because of known issue
> (https://issues.apache.org/jira/browse/MESOS-1385).
>
>
> Thanks,
>
> Vinod Kone
>
>
