----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/#review79430 -----------------------------------------------------------
src/common/resources.cpp <https://reviews.apache.org/r/32149/#comment128786> Do you need to call validate(operation.reserve().resources()) first (like we did in CREATE/DESTROY)? Do you also want to check if each resource is dynamically reserved (i.e., has ReservationInfo, role != `*`)? - Jie Yu On April 7, 2015, 10:25 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32149/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 10:25 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2477 > https://issues.apache.org/jira/browse/MESOS-2477 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 > src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415 > > Diff: https://reviews.apache.org/r/32149/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
