> On April 16, 2015, 4 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4465 > > <https://reviews.apache.org/r/33154/diff/1/?file=926687#file926687line4465> > > > > Is this optional because there are other removals that we don't have > > metrics for? the ones in exited() and reregisteredSlave()? can we have > > metrics for them too while we are at it?
I can add one for when the a new slave registers and replaces the old slave. For exited(), I didn't add a metric since we are removing checkpointing. It doesn't look like the flag is even available anymore? Looks like some further cleanup is required (remove the field in the message, and the comment / logic in `Master::exited`). - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33154/#review80339 ----------------------------------------------------------- On April 14, 2015, 1:46 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33154/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 1:46 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2485 > https://issues.apache.org/jira/browse/MESOS-2485 > > > Repository: mesos > > > Description > ------- > > See [MESOS-2485](https://issues.apache.org/jira/browse/MESOS-2485). > > > Diffs > ----- > > include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 > src/master/master.hpp 6141917644b84edfed9836fa0a005d55a36880e3 > src/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36 > src/master/metrics.hpp 52a83289cfe7e6b6fd8d5bff0774ebe5ce51d0ed > src/master/metrics.cpp 14486bf7130250f561c9fb7a43c95f3fc1e76a4b > > Diff: https://reviews.apache.org/r/33154/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
