----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33155/#review80397 -----------------------------------------------------------
src/tests/master_tests.cpp <https://reviews.apache.org/r/33155/#comment130286> I'm a bit confused on how slave's lifetime affects the metrics collection on master endpoint? - Vinod Kone On April 14, 2015, 1:46 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33155/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 1:46 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2485 > https://issues.apache.org/jira/browse/MESOS-2485 > > > Repository: mesos > > > Description > ------- > > I updated the existing tests to validate the metrics. However, it blocks the > tests due to the slave metrics never getting satisfied. Added a TODO. > > > Diffs > ----- > > src/tests/master_tests.cpp 32b1e9bb58d8046e5363fafe2ab8f662b6c9a666 > src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f > src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 > > Diff: https://reviews.apache.org/r/33155/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
