> On April 14, 2015, 9:28 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, lines 108-114 > > <https://reviews.apache.org/r/27113/diff/4/?file=925777#file925777line108> > > > > This seems to suggest support for multiple "runs" of the client. > > However, if a /run request arrives while the previous run is in progress, > > it looks like this will behave strangely. Did you want to deny requests > > while a run is in progress, or chain the runs after one another?
Caught this state and return an error message for now. > On April 14, 2015, 9:28 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 266 > > <https://reviews.apache.org/r/27113/diff/4/?file=925777#file925777line266> > > > > Could you do a self review of this test body, from the perspective of > > someone approaching this code for the first time? > > > > I had a hard time understanding this, at a basic level what is the > > overall structure of the forking here? It's also a bit tricky to figure out > > the lower level details, like what the `requestPipes` and `resultPipes` are > > for, and why they're needed. What the vectors of pipes are used for, why > > they're needed. Etc. > > > > In the process of being able to articulate what this does, we might > > figure out how we can make it more easily understandable :) Take a look at the updated review. I'll let you mark this as fixed if you approve :-) - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/#review80101 ----------------------------------------------------------- On April 17, 2015, 5:28 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27113/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 5:28 p.m.) > > > Review request for mesos, Ben Mahler, Cody Maloney, Joerg Schad, and Michael > Park. > > > Bugs: MESOS-1980 > https://issues.apache.org/jira/browse/MESOS-1980 > > > Repository: mesos > > > Description > ------- > > Clean up Libprocess for readability / extensibility. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/benchmarks.cpp > a927e4ecd8c8955cd9f85e716173a73a9a21c6cd > > Diff: https://reviews.apache.org/r/27113/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
