> On April 11, 2015, 3:54 a.m., Adam B wrote: > > src/examples/test_hook_module.cpp, lines 80-85 > > <https://reviews.apache.org/r/31028/diff/4/?file=920382#file920382line80> > > > > Create variables like testLabelKey, etc. above so it's easier to track > > all these label k/v strings. > > Niklas Nielsen wrote: > I would prefer if we could defer this to a subsequent review; we use foo, > bar, baz, qux quite a few places for label testing. Is that OK with you? I > can create a JIRA for it now if you'd like.
Separate review/JIRA is fine by me. I just have an aversion to hardcoded strings showing up in multiple places. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/#review79804 ----------------------------------------------------------- On April 11, 2015, 3:03 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31028/ > ----------------------------------------------------------- > > (Updated April 11, 2015, 3:03 a.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 > src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 > > Diff: https://reviews.apache.org/r/31028/diff/ > > > Testing > ------- > > make check (with newly added VerifySlaveRunTaskHook test) > > > Thanks, > > Niklas Nielsen > >
