> On April 2, 2015, 6:23 p.m., Vinod Kone wrote: > > include/mesos/master/allocator.proto, lines 19-23 > > <https://reviews.apache.org/r/31776/diff/6/?file=912077#file912077line19> > > > > Since allocator is within the same Unix process as Master, what is the > > compatibility issue here? > > Alexander Rukletsov wrote: > The comment is related to the protobuf namespace in which `RoleInfo` > lives. Not sure I'm getting what you mean by mentioning that allocator and > Master are in the same Unix process.
I'll create a separate review request for this. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31776/#review78690 ----------------------------------------------------------- On April 15, 2015, 2:16 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31776/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 2:16 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > This is required for out-of-tree allocator modules. RoleInfo protobuf message > has to be extracted into its own public proto file. > > > Diffs > ----- > > include/mesos/master/allocator.proto PRE-CREATION > src/Makefile.am d15a37365bcdd5c3906160b46b389635b38b1673 > src/local/local.hpp 0aa50ef4f44c347eca4b3a409f2a8d03ba321d82 > src/local/local.cpp 289b9bced7bab0d745fe14823efa4e90ec36905e > src/master/allocator/allocator.hpp 91f80501aa9bc733fd53f9cb1ac0f15949a74964 > src/master/allocator/mesos/allocator.hpp > fb898f1175b61b442204e6e38c69ccc2838a646f > src/master/main.cpp 7cce3a0bb808a1cb7bac9acab31eb1c67a15ea9f > src/master/master.hpp 6141917644b84edfed9836fa0a005d55a36880e3 > src/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36 > src/messages/messages.proto 2d242dcfc54f9146721a1b8fbef02e4de050cf58 > src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec > src/tests/fault_tolerance_tests.cpp > a637c32f004638a110390b22cf5b626e904097cf > src/tests/hierarchical_allocator_tests.cpp > 8861bf398e4bb17b0f74eab4f4af26202447ccef > src/tests/master_allocator_tests.cpp > 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 > src/tests/master_authorization_tests.cpp > ac79303645cc1af337b1dca8db244113d0ba6fce > src/tests/master_slave_reconciliation_tests.cpp > e60f601202fcdbb4cafac190e9b09ca6ce925260 > src/tests/master_tests.cpp 32b1e9bb58d8046e5363fafe2ab8f662b6c9a666 > src/tests/mesos.hpp 42e42ac425a448fcc5e93db1cef1112cbf5e67c4 > src/tests/mesos.cpp fc534e9febed1e293076e00e0f5c3879a78df90f > src/tests/rate_limiting_tests.cpp d5c00b8db30fc529bc984417a632cf99eb50eb28 > > Diff: https://reviews.apache.org/r/31776/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0) > > > Thanks, > > Alexander Rukletsov > >
