> On April 8, 2015, 6:38 p.m., Isabel Jimenez wrote: > > src/scheduler/scheduler.cpp, line 239 > > <https://reviews.apache.org/r/32501/diff/2/?file=910148#file910148line239> > > > > Don't we also need to add a TODO in sched.cpp for this to be remove?
The TODO in mesos.proto should be enough IMO because when you remove it, you need to update scheduler.hpp, sched.cpp, java and python bindings for the code to compile. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review79392 ----------------------------------------------------------- On March 31, 2015, 12:06 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32501/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 12:06 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Removed REQUEST call because it is unused. > > > Diffs > ----- > > include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/master/master.hpp 05be911734b8d70c9fa5f3b4a275e8b610621fc5 > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > > Diff: https://reviews.apache.org/r/32501/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
