> On April 8, 2015, 11:41 p.m., Isabel Jimenez wrote: > > src/scheduler/scheduler.cpp, line 583 > > <https://reviews.apache.org/r/32504/diff/2/?file=910157#file910157line583> > > > > Shouldn't we apply this same reasoning in sched.cpp?
Not really. Frameworks currently depend on MasterInfo to know which master they are connected to. With the new API, they will be in explicit control of the connection, so they will know. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32504/#review79452 ----------------------------------------------------------- On March 31, 2015, 12:08 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32504/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 12:08 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they > don't provide much value in a HTTP API world because the scheduler knows > precisely who it is connecting to. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > > Diff: https://reviews.apache.org/r/32504/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
