> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote: > > I'm still not sure whether it's necessary to provide `SlaveID` in the kill > > request. But I'd better comment on MESOS-1127 instead.
made SlaveID optional like we did for Reconcile for backwards compatibility. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/#review79373 ----------------------------------------------------------- On April 3, 2015, 11:40 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32843/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 11:40 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Having SlaveID will help us do better reconciliation when the task is not > found. Also, updated master to handle Call::Kill. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/master/master.hpp 05be911734b8d70c9fa5f3b4a275e8b610621fc5 > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32843/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
