----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/#review80858 -----------------------------------------------------------
I like the further explanation of decorators (but wanted to suggest different wording); it not only sets up the context for the API change, but also further explains how hooks can be used. Can you also add a brief note (probably referencing the modules doc) in docs/upgrades.md for 0.23? docs/modules.md <https://reviews.apache.org/r/33372/#comment130982> s/let's/lets/ docs/modules.md <https://reviews.apache.org/r/33372/#comment130984> s/masterLaunchTaskHooks/masterLaunchTaskHook/ ? docs/modules.md <https://reviews.apache.org/r/33372/#comment130985> "Some hooks take in an object (e.g. TaskInfo) and return all or part of that object (e.g. task labels), so that the hook can modify or replace the contents in-flight. These hooks are referred to as _decorators_." docs/modules.md <https://reviews.apache.org/r/33372/#comment130990> You've got room, so let's use explicit version numbers in the table headers. Before (0.22.x) // we didn't have these in 0.21 right? After (0.23.0+) - Adam B On April 20, 2015, 2:27 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33372/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 2:27 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-2622 > https://issues.apache.org/jira/browse/MESOS-2622 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 > > Diff: https://reviews.apache.org/r/33372/diff/ > > > Testing > ------- > > > Thanks, > > Niklas Nielsen > >
