----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review80972 -----------------------------------------------------------
Ship it! LGTM assuming no functional changes, just code move. src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131163> Do you need them here? src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131165> Do we need this include here? src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131164> Shall this include stay here? src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131157> Not yours, but let's remove empty newlines. src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131158> `#include <process/future.hpp>? src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131159> `#include <mesos/mesos.hpp>`? src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131160> `#include <stout/try.hpp>?` src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131161> Why have you left this one here? It's more than one line, I think you can move it to `.cpp` as well. src/slave/status_update_manager.hpp <https://reviews.apache.org/r/33358/#comment131162> `#include <stout/option.hpp>`? - Alexander Rukletsov On April 21, 2015, 12:38 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33358/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 12:38 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-2609 > https://issues.apache.org/jira/browse/MESOS-2609 > > > Repository: mesos > > > Description > ------- > > Moves the implementation of StatusUpdateStream to a compilation unit. > Also cleans up headers. > > > Diffs > ----- > > src/slave/status_update_manager.hpp > b4d91b22b515195fdb69c89af9c2864e469e7e54 > src/slave/status_update_manager.cpp > fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 > > Diff: https://reviews.apache.org/r/33358/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
