> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 1626-1628 > > <https://reviews.apache.org/r/32845/diff/1/?file=915074#file915074line1626> > > > > Shall we check `framework->pid == from` as we do in > > `Master::unregisterFramework()`? > > > > Also metrcis update > > `++metrics->messages_unregister_framework;` should be migrated to > > `removeFramework()`. > > Vinod Kone wrote: > We do this check for all calls. It is above the switch statement in this > function. > > Metrics, I'll add later.
I see it now, sorry, my bad. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review79381 ----------------------------------------------------------- On April 20, 2015, 8:04 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32845/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 8:04 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Renamed UNREGISTER call to UNSUBSCRIBE for consistency. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32845/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
