----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32123/#review81031 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/containerizer.hpp <https://reviews.apache.org/r/32123/#comment131254> Can we remove the default and just make it explicit? i.e., when we reap it's destroy(containerId, false) and when it's limited it's destroy(containerId, true). src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/32123/#comment131258> Suggest removing default and calling destroy(containerId, false) here. - Ian Downes On March 23, 2015, 12:59 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32123/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 12:59 a.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Fix destroying containerizer during isolator prepare. > This ensures the prepare phase is completed before destroying the container. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > ae61a0fcd19f2ba808624312401f020121baf5d4 > src/slave/containerizer/mesos/containerizer.cpp > fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748 > src/tests/containerizer_tests.cpp 565903b754bbf5891891b183a283aee038eb1b8f > > Diff: https://reviews.apache.org/r/32123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
