----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/#review81038 -----------------------------------------------------------
Ship it! Ship It! - Niklas Nielsen On April 21, 2015, 11:45 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31265/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 11:45 a.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > The factory creates allocator instances in a way identical to how instances > from modules are created. It allows us to use same typed tests for built-in > and modularized allocators. > > > Diffs > ----- > > src/examples/test_allocator_module.cpp PRE-CREATION > src/local/local.cpp 289b9bced7bab0d745fe14823efa4e90ec36905e > src/master/allocator/mesos/allocator.hpp > af27a9bd8299cbff01e04b74db47c86bf247b908 > src/master/main.cpp 7cce3a0bb808a1cb7bac9acab31eb1c67a15ea9f > src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec > src/tests/hierarchical_allocator_tests.cpp > 0b564a74d3f04df46fe52fcbe1bf8d4d1e41c53c > src/tests/mesos.hpp 7744df55a2a31446327da7bd2b16457e90711d22 > > Diff: https://reviews.apache.org/r/31265/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
